rocprof-compute branding update #428

xuchen-amd · 2024-09-24T15:44:06Z

No description provided.

coleramos425 · 2024-10-02T20:30:42Z

Subtask

Publish Omniperf's Grafana Docker image to DockerHub under "rocprof-compute" name (Provide Grafana + Omniperf plugin as Docker image in a public registry like Dockerhub #418) (CC: @njobypet)

coleramos425

See requested subtask above

cmake/omniperf.lua.in

CMakeLists.txt

.github/workflows/tarball.yml

.github/workflows/packaging.yml

.github/workflows/tarball.yml

.github/workflows/packaging.yml

grafana/dashboards/Omniperf_v1.0.5_pub.json

README.md

.azuredevops/rocm-ci.yml

coleramos425

This is in no way an expansive review (I haven't even tried running this code). There are quite a few issues that I caught upon first glance, including some that should have been caught with a basic ctrl+f which makes me suspicious.

I'd like a few others to review before we merge.

.github/workflows/dependabot.yml

.github/workflows/docs.yml

CHANGELOG.md

CMakeLists.txt

docs/conf.py

docs/tutorial/profiling-by-example.rst

coleramos425 · 2024-10-23T17:53:48Z

grafana/dashboards/Omniperf_v1.0.5_pub.json

Do you need to change the name of this file and all files in grafana/dashboards/*.json?

grafana/plugins/omniperf_plugin/src/plugin.json

src/rocprof_compute_base.py

src/rocprof_compute_soc/soc_base.py

dgaliffiAMD · 2024-10-23T18:27:28Z

@xuchen-amd , it looks like you have some unintended changes after rebasing and resolving the merge conflicts.

CMakeLists.txt

Signed-off-by: benrichard-amd <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

tests/test_profile_general.py

README.md

CHANGELOG.md

.github/workflows/docs.yml

.github/CODEOWNERS

.github/ISSUE_TEMPLATE/bug_report.md

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

…md/omniperf into rocprof-compute_branding_update

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

…md/omniperf into rocprof-compute_branding_update

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

CMakeLists.txt

Edit project description based on Fei's feedback Signed-off-by: David Galiffi <[email protected]>

Signed-off-by: Peter Park <[email protected]>

* find/replace Omniperf to ROCm Compute Profiler Signed-off-by: Peter Park <[email protected]> * update name in Sphinx conf Signed-off-by: Peter Park <[email protected]> * mv what-is-omniperf.rst -> what-is-rocprof-compute.rst Signed-off-by: Peter Park <[email protected]> * update Tutorials section Signed-off-by: Peter Park <[email protected]> * add Omniperf as keyword to Conceptual section for internal search Signed-off-by: Peter Park <[email protected]> * update Reference section Signed-off-by: Peter Park <[email protected]> * black fmt conf.py Signed-off-by: Peter Park <[email protected]> * update profile mode and basic usage subsections Signed-off-by: Peter Park <[email protected]> * update how to use analyze mode subsection Signed-off-by: Peter Park <[email protected]> * update install section Signed-off-by: Peter Park <[email protected]> * fix sphinx warnings Signed-off-by: Peter Park <[email protected]> * fix cmd line examples in profile/mode.rst Signed-off-by: Peter Park <[email protected]> * update install decision tree image Signed-off-by: Peter Park <[email protected]> * fix TOC and index Signed-off-by: Peter Park <[email protected]> fix weird wording * fix cli text: deriving rocprofiler-compute metrics... Signed-off-by: Peter Park <[email protected]> * update standalone-gui.rst Signed-off-by: Peter Park <[email protected]> * restore removed doc updates from #428 Signed-off-by: Peter Park <[email protected]> * update ref to Omniperf in index.rst Signed-off-by: Peter Park <[email protected]> * fix grafana connection name to match image Signed-off-by: Peter Park <[email protected]> * update cmds in tutorials Signed-off-by: Peter Park <[email protected]> --------- Signed-off-by: Peter Park <[email protected]>

- Update filenames. - Update executable to `rocprof-compute` - Update update package to `rocprofiler-compute` - Update name in application output and logs - Update name in README files - Update testing and workflows --------- Signed-off-by: Xuan Chen <[email protected]>

* find/replace Omniperf to ROCm Compute Profiler Signed-off-by: Peter Park <[email protected]> * update name in Sphinx conf Signed-off-by: Peter Park <[email protected]> * mv what-is-omniperf.rst -> what-is-rocprof-compute.rst Signed-off-by: Peter Park <[email protected]> * update Tutorials section Signed-off-by: Peter Park <[email protected]> * add Omniperf as keyword to Conceptual section for internal search Signed-off-by: Peter Park <[email protected]> * update Reference section Signed-off-by: Peter Park <[email protected]> * black fmt conf.py Signed-off-by: Peter Park <[email protected]> * update profile mode and basic usage subsections Signed-off-by: Peter Park <[email protected]> * update how to use analyze mode subsection Signed-off-by: Peter Park <[email protected]> * update install section Signed-off-by: Peter Park <[email protected]> * fix sphinx warnings Signed-off-by: Peter Park <[email protected]> * fix cmd line examples in profile/mode.rst Signed-off-by: Peter Park <[email protected]> * update install decision tree image Signed-off-by: Peter Park <[email protected]> * fix TOC and index Signed-off-by: Peter Park <[email protected]> fix weird wording * fix cli text: deriving rocprofiler-compute metrics... Signed-off-by: Peter Park <[email protected]> * update standalone-gui.rst Signed-off-by: Peter Park <[email protected]> * restore removed doc updates from #428 Signed-off-by: Peter Park <[email protected]> * update ref to Omniperf in index.rst Signed-off-by: Peter Park <[email protected]> * fix grafana connection name to match image Signed-off-by: Peter Park <[email protected]> * update cmds in tutorials Signed-off-by: Peter Park <[email protected]> --------- Signed-off-by: Peter Park <[email protected]>

* Rename Omniperf to ROCm Compute Profiler (#428) - Update filenames. - Update executable to `rocprof-compute` - Update update package to `rocprofiler-compute` - Update name in application output and logs - Update name in README files - Update testing and workflows --------- Signed-off-by: Xuan Chen <[email protected]> * Give executable permission to rocprof-compute (#456) Signed-off-by: coleramos425 <[email protected]> * Update VERSION to 3.0.0 (#457) * Update VERSION and README to 3.0.0 * Update version mismatch of profiling data to a warning. Signed-off-by: David Galiffi <[email protected]> * Fix changelog heading Signed-off-by: Peter Park <[email protected]> * External CI: rename pipeline to rocprofiler-compute (#463) Signed-off-by: Daniel Su <[email protected]> * Update branding in documentation (#442) * find/replace Omniperf to ROCm Compute Profiler Signed-off-by: Peter Park <[email protected]> * update name in Sphinx conf Signed-off-by: Peter Park <[email protected]> * mv what-is-omniperf.rst -> what-is-rocprof-compute.rst Signed-off-by: Peter Park <[email protected]> * update Tutorials section Signed-off-by: Peter Park <[email protected]> * add Omniperf as keyword to Conceptual section for internal search Signed-off-by: Peter Park <[email protected]> * update Reference section Signed-off-by: Peter Park <[email protected]> * black fmt conf.py Signed-off-by: Peter Park <[email protected]> * update profile mode and basic usage subsections Signed-off-by: Peter Park <[email protected]> * update how to use analyze mode subsection Signed-off-by: Peter Park <[email protected]> * update install section Signed-off-by: Peter Park <[email protected]> * fix sphinx warnings Signed-off-by: Peter Park <[email protected]> * fix cmd line examples in profile/mode.rst Signed-off-by: Peter Park <[email protected]> * update install decision tree image Signed-off-by: Peter Park <[email protected]> * fix TOC and index Signed-off-by: Peter Park <[email protected]> fix weird wording * fix cli text: deriving rocprofiler-compute metrics... Signed-off-by: Peter Park <[email protected]> * update standalone-gui.rst Signed-off-by: Peter Park <[email protected]> * restore removed doc updates from #428 Signed-off-by: Peter Park <[email protected]> * update ref to Omniperf in index.rst Signed-off-by: Peter Park <[email protected]> * fix grafana connection name to match image Signed-off-by: Peter Park <[email protected]> * update cmds in tutorials Signed-off-by: Peter Park <[email protected]> --------- Signed-off-by: Peter Park <[email protected]> * Update webui branding (#459) * Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <[email protected]> * Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]> * Rename grafana files to RocProfCompute * Rebranding update Missed references mostly in comments --------- Signed-off-by: Xuan Chen <[email protected]> Signed-off-by: coleramos425 <[email protected]> Signed-off-by: David Galiffi <[email protected]> Signed-off-by: Peter Park <[email protected]> Signed-off-by: Daniel Su <[email protected]> Signed-off-by: xuchen-amd <[email protected]> Co-authored-by: xuchen-amd <[email protected]> Co-authored-by: Cole Ramos <[email protected]> Co-authored-by: Peter Park <[email protected]> Co-authored-by: Daniel Su <[email protected]>

xuchen-amd requested review from a team, koomie and coleramos425 as code owners September 24, 2024 15:44

coleramos425 force-pushed the amd-staging branch from 6265391 to 0d15023 Compare September 25, 2024 17:24

coleramos425 mentioned this pull request Oct 2, 2024

Provide Grafana + Omniperf plugin as Docker image in a public registry like Dockerhub #418

Open

coleramos425 requested changes Oct 2, 2024

View reviewed changes

peterjunpark mentioned this pull request Oct 3, 2024

Update branding in documentation #442

Merged

dgaliffiAMD requested changes Oct 10, 2024

View reviewed changes

dgaliffiAMD reviewed Oct 10, 2024

View reviewed changes

grafana/dashboards/Omniperf_v1.0.5_pub.json Show resolved Hide resolved

coleramos425 self-requested a review October 11, 2024 20:27

xuchen-amd requested a review from feizheng10 as a code owner October 16, 2024 16:25

xuchen-amd force-pushed the rocprof-compute_branding_update branch from 48152d6 to 8062ae1 Compare October 16, 2024 20:05

dgaliffiAMD reviewed Oct 16, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

xuchen-amd force-pushed the rocprof-compute_branding_update branch from 9753c80 to 0e7085c Compare October 17, 2024 00:19

dgaliffiAMD approved these changes Oct 17, 2024

View reviewed changes

dgaliffiAMD reviewed Oct 17, 2024

View reviewed changes

README.md Show resolved Hide resolved

danielsu-amd reviewed Oct 18, 2024

View reviewed changes

.azuredevops/rocm-ci.yml Outdated Show resolved Hide resolved

xuchen-amd force-pushed the rocprof-compute_branding_update branch from ff39865 to 6b53298 Compare October 22, 2024 01:39

dgaliffiAMD force-pushed the rocprof-compute_branding_update branch from ac3de62 to 3417f50 Compare October 23, 2024 02:00

xuchen-amd force-pushed the rocprof-compute_branding_update branch from c32a9a1 to 8e4e774 Compare October 23, 2024 05:43

dgaliffiAMD approved these changes Oct 23, 2024

View reviewed changes

xuchen-amd force-pushed the rocprof-compute_branding_update branch from 4644a79 to ecaf46a Compare October 23, 2024 15:25

coleramos425 requested changes Oct 23, 2024

View reviewed changes

dgaliffiAMD self-requested a review October 23, 2024 18:28

dgaliffiAMD reviewed Oct 24, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

benrichard-amd added 3 commits October 29, 2024 00:34

Update to work with rocprof v1

40d4e65

Signed-off-by: benrichard-amd <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Remove unused method

b31fa31

Signed-off-by: benrichard-amd <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Fix code formatting

2ef632e

Signed-off-by: benrichard-amd <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

dgaliffiAMD requested changes Oct 29, 2024

View reviewed changes

xuchen-amd and others added 15 commits October 29, 2024 15:12

Remove unintended changes.

14b3dbe

Update docs/tutorial/profiling-by-example.rst

9dc2a78

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Update .github/workflows/docs.yml

d00ea74

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Update CHANGELOG.md

f28ed48

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Update README.md

f4ad866

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Remove duplicates and fix unintended removal.

923e4eb

Merge branch 'rocprof-compute_branding_update' of github.com:xuchen-a…

705ed7a

…md/omniperf into rocprof-compute_branding_update

Update src/utils/specs.py

5c029d0

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Update docs/tutorial/includes/vector-memory-operation-counting.rst

d35c21c

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Update docs/conf.py

9e0740f

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Update docs/tutorial/includes/infinity-fabric-transactions.rst

d6f6428

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Update docs/tutorial/includes/occupancy-limiters-example.rst

213a36c

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

Fix unintended changes.

d3a5f2c

Merge branch 'rocprof-compute_branding_update' of github.com:xuchen-a…

f2c3d0e

…md/omniperf into rocprof-compute_branding_update

Update docs/how-to/profile/mode.rst

ab12160

Co-authored-by: David Galiffi <[email protected]> Signed-off-by: xuchen-amd <[email protected]>

xuchen-amd requested a review from dgaliffiAMD October 30, 2024 18:50

dgaliffiAMD approved these changes Oct 30, 2024

View reviewed changes

feizheng10 reviewed Oct 31, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

feizheng10 approved these changes Oct 31, 2024

View reviewed changes

Update CMakeLists.txt

f7414d9

Edit project description based on Fei's feedback Signed-off-by: David Galiffi <[email protected]>

dgaliffiAMD merged commit 31b4de1 into ROCm:amd-staging Nov 1, 2024
9 of 10 checks passed

peterjunpark added a commit to peterjunpark/omniperf that referenced this pull request Nov 5, 2024

restore removed doc updates from ROCm#428

58aa6dc

peterjunpark added a commit to peterjunpark/omniperf that referenced this pull request Nov 5, 2024

restore removed doc updates from ROCm#428

f92d6ef

Signed-off-by: Peter Park <[email protected]>

peterjunpark added a commit to peterjunpark/omniperf that referenced this pull request Nov 5, 2024

restore removed doc updates from ROCm#428

74a1bb2

Signed-off-by: Peter Park <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rocprof-compute branding update #428

rocprof-compute branding update #428

xuchen-amd commented Sep 24, 2024 •

edited

Loading

coleramos425 commented Oct 2, 2024 •

edited by xuchen-amd

Loading

coleramos425 left a comment

coleramos425 left a comment

coleramos425 Oct 23, 2024

dgaliffiAMD commented Oct 23, 2024

rocprof-compute branding update #428

rocprof-compute branding update #428

Conversation

xuchen-amd commented Sep 24, 2024 • edited Loading

coleramos425 commented Oct 2, 2024 • edited by xuchen-amd Loading

Subtask

coleramos425 left a comment

Choose a reason for hiding this comment

coleramos425 left a comment

Choose a reason for hiding this comment

coleramos425 Oct 23, 2024

Choose a reason for hiding this comment

dgaliffiAMD commented Oct 23, 2024

xuchen-amd commented Sep 24, 2024 •

edited

Loading

coleramos425 commented Oct 2, 2024 •

edited by xuchen-amd

Loading